Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix criticals #181

Open
wants to merge 7 commits into
base: staging
Choose a base branch
from
Open

Fix criticals #181

wants to merge 7 commits into from

Conversation

bkochauri-memphis
Copy link
Contributor

How Has This Been Tested?

Please describe the tests you ran to verify your changes and note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the knowledge base (if needed)
  • My changes generate no new warnings
  • I have verified that the specification is met and all functionalities are working as expected

Reviewer Score - 0-100%

  • Tests have been done and meaningfully described - (25%)

    • Ensure all necessary tests are conducted, covering the critical paths and edge cases.
    • Descriptions should be clear, documenting the test intent, steps, and outcomes for reproducibility and transparency.
  • Meeting Task Specifications (25%)

    • This includes security, observability, and cost-efficiency aspects.
    • Ensure that the task requirements are fully met and that the implementation aligns with the specifications provided.
  • Writing Readable Code (20%)

    • Write code that is easy to read and understand.
    • Use clear and meaningful variable names, and include comments where necessary.
  • Attention to the folder structures in automation tools and repositories (20%)

    • Make sure the folder hierarchy and the names are clear and meaningful.
  • Attention to Edge Cases (10%)

    • Identify and handle edge cases that may not be immediately obvious.
    • Demonstrate thorough testing and consideration of potential issues.

@@ -316,7 +316,7 @@ config:
container:
image:
repository: nats
tag: 2.10.20-alpine
tag: 2.10.26-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkochauri-memphis Its not the correct way to upgrade nats or telegraf. You should check updates of the whole helm chart and update it accordingly if needed + version in Chart.yaml of SSM and the components.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeraBr Nats chart is updated, regarding telegraf chart we are on the last version.

Copy link
Contributor

@valeraBr valeraBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkochauri-memphis Our Chart.yaml should be updated as well with actual helm chart versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants