feat: add details about aws lambda plugins #981
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| ## Using with AWS Lambda Plugins / Extensions | ||
|
|
||
| If you are using AWS Lambda plugins / extensions / anything that adds events to the lambda function (e:g `serverless-plugin-warmup`), then you may need to filter them and skip passing them to SuperTokens. |
There was a problem hiding this comment.
use commas between the enumeration: "plugins, extensions or anything..."
There was a problem hiding this comment.
rephrase it so that the it doesn't seem like it's something optional: "you have to filter them before calling the SuperTokens handler.`
There was a problem hiding this comment.
rephrase it so that the it doesn't seem like it's something optional: "you have to filter them before calling the SuperTokens handler.`
It is supposed to be optional as this can lead to errors in some cases, not all so I think it's better we keep this as optional.
|
|
||
| If you are using AWS Lambda plugins / extensions / anything that adds events to the lambda function (e:g `serverless-plugin-warmup`), then you may need to filter them and skip passing them to SuperTokens. | ||
|
|
||
| These kind of events lack request details that SuperTokens expects, that are present in a normal request, and thus might lead to un-intended errors. |
There was a problem hiding this comment.
remove the that are present... part. It's not necessary. just join the phrase on and thus.
| @@ -348,3 +348,62 @@ handler = Mangum(app) | |||
|
|
|||
| </BackendTabs.TabItem> | |||
| </BackendTabs> | |||
|
|
|||
| ## Using with AWS Lambda Plugins / Extensions | |||
There was a problem hiding this comment.
I think it would be better to have this as an optional step.
Something like:
3.5 Filter additional plugins or extensions {{optional}}
|
|
||
| #### 3.5 Filter additional plugins or extensions {{optional}} | ||
|
|
||
| If you are using AWS Lambda plugins, extensions, or anything that adds events to the lambda function (e.g. `serverless-plugin-warmup`), then you may need to filter them and skip passing them to SuperTokens. |
There was a problem hiding this comment.
"then you may need to prevent calling SuperTokens with them". Avoid repetition of them and remove redundant sentence.
Summary of change
This PR adds details about using plugins with AWS lambda and how to filter and not pass them to SuperTokens.
Link to change
Related issues
Checklist
cd v3 && npm run build)