Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATH expansion in comment #230

Closed
wants to merge 1 commit into from

Conversation

jtraglia
Copy link
Contributor

I ran into an issue building blst on Windows via a GitHub CI runner:

./build.bat
The input line is too long.
The syntax of the command is incorrect.

With your help, we discovered that %PATH% was being expanded twice. First in the command & again in the comment. This caused the command to be approximately 2x the length of PATH. If the system were configured with a large PATH, this could cause the set PATH command to be longer than the 8192-character limit and, as a result, fail.

@dot-asm
Copy link
Collaborator

dot-asm commented Aug 15, 2024

Thanks! As we looked into it yesterday, I've identified an additional potential problem related to msys interference. [And a typo.] Trouble is that it, msys, provides link.exe, which would be a problem if it gets ahead of MSVC linker on the PATH. Hence the suggestion is to close this and I'll commit a fix that addresses both problems [and the typo]...

@jtraglia
Copy link
Contributor Author

Okay yeah that's totally fine. Will close this.

@jtraglia jtraglia closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants