Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react 19 to peer deps #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shadowoff09
Copy link

This PR:

Adds React 19 to peer reps for the monaco-react package

@suren-atoyan
Copy link
Owner

React 19 is still in beta; I think it would be better to wait for it to be fully released, then test it and make adjustments if needed, and only then support it. wdyt?

@shadowoff09
Copy link
Author

React 19 is still in beta; I think it would be better to wait for it to be fully released, then test it and make adjustments if needed, and only then support it. wdyt?

Yes I agree, other libraries already support React 19, so I was thinking if you could merge my PR to support React 19, but you are right, we should wait.

@Johnhersh
Copy link

Came here looking for this. NextJS 15 is not an RC but it does use React19RC. This means upgrading to NextJS15 fails because of this

@shadowoff09
Copy link
Author

Came here looking for this. NextJS 15 is not an RC but it does use React19RC. This means upgrading to NextJS15 fails because of this

Exactly, its the only dependency failing.

@acdvorak
Copy link

acdvorak commented Dec 5, 2024

React v19.0.0 was just released an hour ago: https://www.npmjs.com/package/react/v/19.0.0 😀

@suren-atoyan
Copy link
Owner

React v19.0.0 was just released an hour ago: https://www.npmjs.com/package/react/v/19.0.0 😀

ok, I'll work on the new version

ape-physter

This comment was marked as outdated.

@suren-atoyan
Copy link
Owner

#656 (comment)

@suren-atoyan
Copy link
Owner

hi everyone 👋

please try out the v4.7.0-rc.0 version (use npm install @monaco-editor/react@next or yarn add @monaco-editor/react@next) and let us know here if you face any issues

@gkorland
Copy link

Thanks for the quick update! When do you expect to release a GA version?

@suren-atoyan
Copy link
Owner

Thanks for the quick update! When do you expect to release a GA version?

I am waiting for some feedback from people that use React 19.

Screenshot 2024-12-24 at 02 08 56

As you can see, we have a small amount of downloads for this version. We need to wait a bit more.

@sanskar-19
Copy link

sanskar-19 commented Dec 26, 2024

Is there any update/expected timeline on this?

@suren-atoyan getting this error with ^4.7.0-rc.0 -

image

React v19, @types/react@19, next@15

@suren-atoyan
Copy link
Owner

Is there any update/expected timeline on this?

@suren-atoyan getting this error with ^4.7.0-rc.0 -

image React v19, @types/react@19, next@15

Screenshot 2025-01-03 at 00 02 29

I've just tried next@15m react@19 and @monaco-editor/[email protected] and I haven't faced any issues yet. Could you please share more about your setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants