-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add react 19 to peer deps #651
base: master
Are you sure you want to change the base?
Conversation
React 19 is still in beta; I think it would be better to wait for it to be fully released, then test it and make adjustments if needed, and only then support it. wdyt? |
Yes I agree, other libraries already support React 19, so I was thinking if you could merge my PR to support React 19, but you are right, we should wait. |
Came here looking for this. NextJS 15 is not an RC but it does use React19RC. This means upgrading to NextJS15 fails because of this |
Exactly, its the only dependency failing. |
React |
ok, I'll work on the new version |
hi everyone 👋 please try out the |
Thanks for the quick update! When do you expect to release a GA version? |
Is there any update/expected timeline on this? @suren-atoyan getting this error with React v19, @types/react@19, next@15 |
I've just tried next@15m react@19 and @monaco-editor/[email protected] and I haven't faced any issues yet. Could you please share more about your setup? |
This PR:
Adds React 19 to peer reps for the monaco-react package