Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNP-1654 completion handler macro #12

Merged
merged 1 commit into from
Jul 2, 2024
Merged

SNP-1654 completion handler macro #12

merged 1 commit into from
Jul 2, 2024

Conversation

Goldilocks97
Copy link
Contributor

Что сделано

  • Добавлен макрос completion handler
  • Поправлен код в группе Signals: общий код вынесен в отдельный объект (как в implementation, так и в tests)
  • Улучшен темплейт с макросом
  • EmptyClosure и Closure вынесены из Core проекта в SurfCore

Как проверить

  • Запустить тесты

@Goldilocks97 Goldilocks97 requested a review from NullIsOne July 2, 2024 08:06
@Goldilocks97 Goldilocks97 self-assigned this Jul 2, 2024
@NullIsOne NullIsOne merged commit 6971e0d into main Jul 2, 2024
1 check passed
@NullIsOne NullIsOne deleted the SNP-1654-completion-handler branch July 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullIsOne NullIsOne NullIsOne approved these changes

Assignees

@Goldilocks97 Goldilocks97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goldilocks97 @NullIsOne