Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture #10

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Architecture #10

wants to merge 7 commits into from

Conversation

ccitygril
Copy link

  • сделана верста
  • добавлен Elementary
  • проведен небольшой рефактор
  • в процессе di

Copy link
Collaborator

@danyaao danyaao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом выглядит круто. Только по поводу структуры проекта - у тебя почти в папку ui грубо говоря попали фичи. Лучше сделать всё-таки папку features в lib, где у тебя будут лежать theme и image, в image перенести все папки data, di и т.д. из lib и создать папку screens, где уже разместить свои elementary-экраны

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

di_scope*

@freezed
class ImageEntity with _$ImageEntity {
const factory ImageEntity({
required int id,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Скорее всего id у нас будут строки, а точнее пути до файлов

@@ -0,0 +1,5 @@
import 'package:flutter/material.dart';

class AppColor {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А это что и зачем?

import 'package:flutter/material.dart';
import 'package:surf_flutter_summer_school_24/ui/ui_kit/color/color_theme.dart';

abstract class AppThemeData {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оно всё-таки должно быть в uikit

}
}

class PageCarousel extends StatefulWidget {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не очень понимаю, а это точно что-то нужное?

Comment on lines +15 to +19
@override
void initWidgetModel() {
super.initWidgetModel();
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если пустой, то не надо переопределять метод

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А, ты сюда подгрузку планируешь добавить. Тогда ок

Widget build(BuildContext context) {
return Scaffold(
appBar: const CustomAppBar(),
body: Column(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А смайлик?

Comment on lines +16 to +17
ElevatedButton(
onPressed: () {}, child: const Text("ПОПРОБОВАТЬ СНОВА"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кнопочку лучше вынести в отдельный виджет

@danyaao
Copy link
Collaborator

danyaao commented Jul 25, 2024

Только сюда не сливай, сливай в свой репозиторий

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants