Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VueJs(complete page): place completePage content between header / footer #9266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xibman
Copy link
Contributor

@xibman xibman commented Jan 6, 2025

Improvement

The completePage content is not between the slot header / footer available with addLayoutElement.

Move completePage content between the previous slot.

@tsv2013
Copy link
Member

tsv2013 commented Jan 10, 2025

@xibman Thank you for the contribution! We highly appreciate it. We support several frameworks (Angular, React and Vue) and implementing every feature for them all at once to have consistent rendering. It's written in our contributing guide - https://github.com/surveyjs/survey-library/blob/master/CONTRIBUTING.md
We will be happy to receive this fix for all supported frameworks. If you will face any problems with testcafe screenshot tests, we'll help you with it.

@tsv2013 tsv2013 self-assigned this Jan 10, 2025
@xibman
Copy link
Contributor Author

xibman commented Jan 10, 2025

@tsv2013 Thanks for the message.
On it bext week for the other framework and test

@xibman
Copy link
Contributor Author

xibman commented Jan 17, 2025

@tsv2013 Change made on Angular to align position of the completePage between header /footer.

On react it seems already good when i check next lines

https://github.com/surveyjs/survey-library/blob/aa9a66967714a631e49afdbfb632acf068eb3b4c/packages/survey-react-ui/src/reactSurvey.tsx#L115C10-L123C18

And the renderResult variable:

let renderResult: React.JSX.Element | null;
.

For the test if you can explain me, i'm welcome to fix them.

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants