feedback updates

suse-edge · Oct 21, 2024 · 121fb87 · 121fb87
1 parent cdca128
commit 121fb87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/image/validation/kubernetes.go b/pkg/image/validation/kubernetes.go
@@ -117,11 +117,10 @@ func validateNetwork(k8s *image.Kubernetes) []FailedValidation {
 	var failures []FailedValidation
 
 	if k8s.Network.APIVIP == "" {
-		if len(k8s.Nodes) >= 1 {
+		if len(k8s.Nodes) > 1 {
 			failures = append(failures, FailedValidation{
-				UserMessage: "The 'apiVIP' field is required in the 'network' section when defining entries under 'nodes'.",
+				UserMessage: "The 'apiVIP' field is required in the 'network' section for multi node clusters.",
 			})
-			return failures
 		}
 
 		return failures

diff --git a/pkg/kubernetes/cluster.go b/pkg/kubernetes/cluster.go
@@ -55,8 +55,8 @@ func NewCluster(kubernetes *image.Kubernetes, configPath string) (*Cluster, erro
 		return &Cluster{ServerConfig: serverConfig}, nil
 	}
 
-	ip, ipErr := netip.ParseAddr(kubernetes.Network.APIVIP)
-	if ipErr != nil {
+	ip, err := netip.ParseAddr(kubernetes.Network.APIVIP)
+	if err != nil {
 		return nil, fmt.Errorf("parsing kubernetes APIVIP address: %w", ipErr)
 	}