[IMP] sustainability: validity date tests #244
+196
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d invoice creation in tests Enhance the test setup by adding more carbon factors, values, and types. Introduce a new product, account, and invoice creation to simulate real-world scenarios. This improves test coverage and ensures robustness in handling various carbon factor configurations and related entities.
Move carbon factor and related setup from common.py to test_conversion.py to streamline test setup and improve maintainability. This change reduces redundancy and ensures that test data is only initialized where necessary, enhancing the clarity and focus of the test suite.
Add creation of a carbon factor value with a specific date and value to ensure the default fallback factor has an associated value. This enhances test coverage by verifying the behavior of carbon factor values in the system.
Add `test_carbon_computation.py` to verify carbon factor values are correctly applied based on invoice dates. This ensures the system accurately computes carbon values for both matching and earlier invoice dates, enhancing reliability in sustainability calculations.
|
Hi @BonnetAdam, @jguenat, |
3 tasks
BonnetAdam
reviewed
Jan 21, 2025
| @@ -8,13 +8,18 @@ class CarbonCommon(TransactionCase): | |||
| def setUpClass(cls): | |||
| super().setUpClass() | |||
|
|
|||
| # Disable tracking test suite | |||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) | |||
There was a problem hiding this comment.
you can directly add the no_reset_password=True to this context
There was a problem hiding this comment.
why not making a code suggestion directly, while explaining why you want this change?
… category setup to streamline test setup and improve maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues