[ADD] sustainability_employee_commuting: remote work management #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce functionality to track and compute carbon emissions from employee remote work. Extend existing models and cron jobs to support this feature, allowing for automatic monthly calculations. Enhance configuration settings to manage remote work emission factors, journals, and accounts. This update addresses the growing need to account for remote work's environmental impact, providing a comprehensive solution for sustainability tracking.
…o ensure accurate data mapping
…ng and remote work Introduce test suite to ensure carbon factors for commuting and remote work are processed correctly. Establishes a common setup for carbon factors and validates expected outcomes for cron job executions.
Renames `_cron_remote_work_carbon_account_move_create` to `_cron_carbon_remote_work_account_move_create` for improved clarity and consistency in naming conventions across the codebase.
Consolidate commuting and remote work carbon accounting cron jobs into a single function to reduce code duplication and improve maintainability. Introduce a mode parameter to handle different carbon accounting types, ensuring flexibility and scalability. Update XML configurations and tests to align with the new unified function.
…ning _get_all_contracts method
Adjust carbon_value in common.py to reflect accurate emissions for bicycle and remote work. Update expected results in test_commuting.py to align with corrected carbon values.
Simplify the cron job function calls by removing the unused to_post argument. This change enhances code readability and reduces unnecessary complexity. Adjust related tests and model logic to align with this refactor.
…lter by unit of measure
The addition of the has_location field allows for more precise tracking of employee location status, enhancing data accuracy. The refactoring in res_company improves the efficiency of employee contract retrieval by leveraging the new field, ensuring that only relevant employees are processed.
…t location and fix commuting test expected result Add a new test case for an employee without a location to ensure coverage for this scenario. Adjust the expected result in the commuting test to reflect the correct total value calculation.
Refactor test to calculate the total signed value of all carbon line origins instead of just one. Adjust expected result to reflect the aggregated value, ensuring the test accurately validates the commuting carbon footprint calculation.
… date to ensure accurate data retrieval
…tion Enhance code maintainability by extracting repeated logic into dedicated methods. Introduce helper functions for deleting existing account moves, fetching employees with contracts, calculating averages, preparing account move lines, and creating account moves. This refactoring reduces redundancy, improves readability, and ensures consistency across the codebase. Additionally, improve error handling by logging detailed error messages and notifying employees of issues during remote work carbon processing.
…error logging Enhance `get_employees_with_contracts` to accept a domain filter, improving flexibility. Simplify error logging by removing employee-specific notifications, focusing on general error messages.
…ployee setups Add tests for various employee configurations, including those with home and office locations, no location, and no contract. Adjust expected results to reflect updated scenarios. Improve test documentation for clarity on remote work carbon emission calculations.
…ecords into batch operations for efficiency and readability
|
Hi @BonnetAdam, |
BonnetAdam
reviewed
Jan 30, 2025
|
|
||
| DAYS = [ |
There was a problem hiding this comment.
why have you duplicated the variable ?
from odoo.addons.hr_homeworking.models.hr_homeworking import DAYS ?
There was a problem hiding this comment.
i didn't duplicate any variable, to what are u referring?
Comment on lines
91
to
98
| "monday_location_id", | ||
| "tuesday_location_id", | ||
| "wednesday_location_id", | ||
| "thursday_location_id", | ||
| "friday_location_id", | ||
| "saturday_location_id", | ||
| "sunday_location_id", | ||
| "exceptional_location_id", |
There was a problem hiding this comment.
Isn't this possible ?
Suggested change
| "monday_location_id", | |
| "tuesday_location_id", | |
| "wednesday_location_id", | |
| "thursday_location_id", | |
| "friday_location_id", | |
| "saturday_location_id", | |
| "sunday_location_id", | |
| "exceptional_location_id", | |
| **DAYS |
There was a problem hiding this comment.
yes but like this
@api.depends( *DAYS, "exceptional_location_id", )
| @@ -24,16 +24,46 @@ class ResConfigSettings(models.TransientModel): | |||
| related="company_id.employee_commuting_carbon_cronjob_active", | |||
| readonly=False, | |||
| ) | |||
| employee_remote_work_carbon_factor_id = fields.Many2one( | |||
| "carbon.factor", | |||
There was a problem hiding this comment.
Suggested change
| "carbon.factor", | |
| comodel_name="carbon.factor", |
There was a problem hiding this comment.
if you check in the code above comodel name is not used
employee_commuting_carbon_factor_id = fields.Many2one(
"carbon.factor",
related="company_id.employee_commuting_carbon_factor_id",
readonly=False,
)
employee_commuting_journal_id = fields.Many2one(
"account.journal",
related="company_id.employee_commuting_journal_id",
readonly=False,
)
employee_commuting_account_id = fields.Many2one(
"account.account",
related="company_id.employee_commuting_account_id",
readonly=False,
)
employee_commuting_carbon_cronjob_active = fields.Boolean(
"Cron job active",
related="company_id.employee_commuting_carbon_cronjob_active",
readonly=False,
)
| from odoo.tests import TransactionCase | ||
|
|
||
|
|
||
| class CarbonCommon(TransactionCase): |
There was a problem hiding this comment.
Why don't Inherit sustainability common ?
There was a problem hiding this comment.
because i dont need all that stuff, i think it's better to do module specific common tests setup. here we are in sustainibility_employee_commuting and it's better to have a "dedicated" test setup imo
test(common.py): add cleanup of demo data to ensure test isolation
…constant in _compute_work_days_home method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calculate carbon emission for home working employees
Related Issues
Self proofreading checklist
and meets the project's coding standards?
reflect your changes?
run upon committing to catch any potential issues?