-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update static models to use 0.7.11 models #1728
feat: update static models to use 0.7.11 models #1728
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This pull request updates static models to use version 0.7.11, but it's still in draft stage due to issues with model loading. The changes primarily affect the power estimation functionality, with key modifications including:
Observations and suggestions:
|
9b6945a
to
1620112
Compare
af67668
to
6f95209
Compare
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
54366e9
to
ecd5f54
Compare
Previously, when DISABLE_POWER_METER is set, kepler would still probe system for power-meters resulting in kepler_node_info to produce incorrect results for components_power_source and platform_power_source. E.g. kepler_node_info{ components_power_source="rapl-sysfs", cpu_architecture="Skylake", instance="kepler-latest:8888", job="latest", platform_power_source="acpi", source="os" } The commit fixes this to use the fake power-meters so that kepler_node_info now shows ``` kepler_node_info{components_power_source="estimator", cpu_architecture="Skylake", instance="kepler-dev:8888", job="dev", platform_power_source="none", source="os" } ``` Signed-off-by: Sunil Thaha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm Thank you so much!
NOTE:
intel_rapl_DynPower
has not been updated sinceSGDRegressor for Dynamic Power Node Type 0 is missing https://github.com/sustainable-computing-io/kepler-model-db/tree/main/models/v0.7/ec2-0.7.11/rapl-sysfs/DynPower/BPFOnly
After updating the models to the latest, here are the changes on my machine
NOTE:
kepler-latest
reports power_sources incorrectly (fixed in this pr; see "dev")Platform / Idle
Platform / Dynamic
Package / Idle
Package / dynamic