Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix model creation functions #1742

Merged

Conversation

sthaha
Copy link
Collaborator

@sthaha sthaha commented Aug 28, 2024

This PR includes

  • fixing the typo Powe -> Power
  • reorganise the functions to exit early and log errors and info

Tested locally using dev compose files

image image image

@sthaha sthaha requested a review from sunya-ch August 28, 2024 02:21
Copy link
Contributor

github-actions bot commented Aug 28, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This PR refactors model creation functions in pkg/model to improve code readability and maintainability. Key changes include:

  • Fixing typos ("Powe" to "Power")
  • Reorganizing functions to exit early and log errors and info
  • Improving code readability and maintainability

Impact: These changes correct naming conventions without affecting function signatures or external interface behavior. However, they may impact power estimation results under certain conditions.

Observation: The changes seem to focus on internal implementation details, which is a good practice for maintainability. It's essential to verify that the power estimation results are accurate and unaffected by these changes.

Suggestion: Consider adding unit tests or integration tests to ensure the power estimation results are correct and consistent before merging this PR.

Copy link
Collaborator

@sunya-ch sunya-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thank you.

@sunya-ch sunya-ch merged commit 79cace5 into sustainable-computing-io:main Aug 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants