Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to google UUID #24

Closed
wants to merge 2 commits into from
Closed

Switch to google UUID #24

wants to merge 2 commits into from

Conversation

lkramer
Copy link

@lkramer lkramer commented Jun 21, 2019

This is my attempt to address #16. I ran into a use case where I needed to use guid, and decided I'd have a go at it.

@sv
Copy link
Owner

sv commented Jun 22, 2019

thanks for contribution. Will have a look when i have some time. There are quite a few pending fixes/improvements that I need to push as well.
For new([16]uint8) any reason why you don't use byte here?

@lkramer
Copy link
Author

lkramer commented Jun 22, 2019

There isn't. I will fix. (The reason is that another 3rd party library I'm integrating with stores it as [16]uint8, but [16]byte is definitely correct).

I actually notice that I made a mistake with the line in general. It should not have changed, the original was fine and will still work.

@sv
Copy link
Owner

sv commented Aug 17, 2019

As this will be breaking change as well, how about merging it to v1beta branch?
Also google.uuid repo saying this:
One loss due to this change is the ability to represent an invalid UUID (vs a NIL UUID).
Would it affect 0Ng coming from kdb?

@lkramer lkramer closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants