Skip to content

Commit

Permalink
Remove gdb disclaimer
Browse files Browse the repository at this point in the history
As long as dap messages are received in the correct order stack trace
resolution does not err.  This was caused by an bug in jsonrpc fork.
  • Loading branch information
svaante committed Mar 2, 2024
1 parent b1a3229 commit 73249cd
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions dape.el
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@
:cwd "."
:program "lib/main.dart"
:toolArgs ["-d" "all"])
;; gdb is not fully functional with an thread count > 1
;; See: `dape--info-threads-all-stack-trace-disable'
(gdb
modes (c-mode c-ts-mode c++-mode c++-ts-mode)
command-cwd dape-command-cwd
Expand Down Expand Up @@ -3206,18 +3204,10 @@ displayed."
;; TODO Add bindings for individual threads.
)

;; TODO Report gdb bug
(defvar dape--info-threads-all-stack-trace-disable nil
"Disable stack information for non selected threads.
GDB fails fetching stack variables if an stack trace for another
thread is in flight, which happens when *dape-info Threads* and
*dape-info Scopes* are updated at the same time.")

(defun dape--info-threads-all-stack-trace (conn cb)
"Populate CONN stack frame data for non selected threads.
See `dape-request' for expected CB signature."
(if (or dape--info-threads-all-stack-trace-disable
(not (dape--threads conn)))
(if (not (dape--threads conn))
(dape--request-return cb)
(let ((responses 0))
(dolist (thread (dape--threads conn))
Expand Down

0 comments on commit 73249cd

Please sign in to comment.