Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other method to enrich mix material library #25

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FusionSandwich
Copy link
Contributor

This method uses Paul's suggestion. The potential downside is that you now rely on the initial and output scripts. Depending on how we want the overall workflow to be, I think will influence which works better.

This method uses Paul's suggestion. The potential downside is that you now rely on the initial and output scripts. Depending on how we want the overall workflow to be, I think will influence which works better.
@gonuke
Copy link
Member

gonuke commented Jul 17, 2024

I am not sure this is the right approach. Why not require people to make an enriched "pure material" and then provide that the the standard method for mixing materials. This helps avoid duplication of code.

@FusionSandwich
Copy link
Contributor Author

If you're looking at varying the enrichment like when Edgar and I did the sensitive analysis it's a lot easier this way. I was also thinking that if any of the fission-fusion projects wanted to use this database it'd be useful for making their enriched materials.

@gonuke
Copy link
Member

gonuke commented Jul 17, 2024

I think there's a way to make it nearly as easy without this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants