Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating 404 page design #28

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Updating 404 page design #28

wants to merge 9 commits into from

Conversation

moudev
Copy link
Member

@moudev moudev commented May 3, 2020

Antes de enviar el Pull Request

  • Confirmo que revisé que mis cambios funcionan
  • He adjuntado una imagen de cómo se ven mis cambios (si aplica)
  • He ejecutado prettier en los archivos de mis cambios

Descripción

  • Actualizando el estilo de la página 404

Capturas

  • [Mobile] 404

Mobile 404

  • [Desktop] 404

Desktop 404

Updating index page with the feature to show data extracted
from the Wordpress API, this data is extracted from
a page that needs to have the name 'content-page-home' because
the page will be searched by its URL Slug.

If the page hasn't been created a message with the instructions
will be displayed. The index page gets and passes it to the
layout component that contains the Header component, after
the data is passed from layout component to Header component.

Important; for this to works it is important install the
Advanced Custom Fields plugin in our WP backend and
create specific fields, this fields names are in the index
page graqhql query.
https://www.wpgraphql.com/acf/

  - Adding validations in gatsby-node file to create pages
    from data of the Wordpress API
  - Updating .eslintrc file whit rule to pass error that
    occurred for the validations added in gatsby-config
  - Updating the index page to get custom fields from the Wordpress
    API
  - Updating the header component to display data from the
    Wordpress API
Adding styled sections of information in the index page,
this data is from the WP API. The sections added are;

- Our motivations
- About Us
- Our Initiatives

  - Adding text-color in tailwind config file
  - Adding sections in the index page file, the data
    of these sections are custom fields created in
    the WP backend with the plugin "Advanced Custom Fields",
    if you want to see the names of these ACFs you can look at
    'src/pages/index.js' file on its graphql query or
    you can look at;
    https://github.com/svconectado/website/wiki
  - Adding prettier rules in the ESLint config file
  - Fixing warnings files with the rules of prettier
  - Adding page-template with the difference that this template
    doesn't show the title and author information
The header component only will be displayed on the main page
of the website.

The menu component has a scroll eventListener, this event is
to set the menu background when the route is "/" because
the menu component won't have background and image when is
in the top of the page, in the other pages, the menu will have
background and image and the scroll eventListener will be
disabled.

  - Updating menu component file
  - Updating layout component to receive showHeader prop
  - Updating the page-template to display the title page
  - Adding 404 image
@moudev moudev linked an issue May 3, 2020 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@moudev moudev requested a review from trejo08 May 6, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dar estilo a la página de 404
1 participant