-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating 404 page design #28
Open
moudev
wants to merge
9
commits into
develop
Choose a base branch
from
feature/add-404-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating index page with the feature to show data extracted from the Wordpress API, this data is extracted from a page that needs to have the name 'content-page-home' because the page will be searched by its URL Slug. If the page hasn't been created a message with the instructions will be displayed. The index page gets and passes it to the layout component that contains the Header component, after the data is passed from layout component to Header component. Important; for this to works it is important install the Advanced Custom Fields plugin in our WP backend and create specific fields, this fields names are in the index page graqhql query. https://www.wpgraphql.com/acf/ - Adding validations in gatsby-node file to create pages from data of the Wordpress API - Updating .eslintrc file whit rule to pass error that occurred for the validations added in gatsby-config - Updating the index page to get custom fields from the Wordpress API - Updating the header component to display data from the Wordpress API
Adding styled sections of information in the index page, this data is from the WP API. The sections added are; - Our motivations - About Us - Our Initiatives - Adding text-color in tailwind config file - Adding sections in the index page file, the data of these sections are custom fields created in the WP backend with the plugin "Advanced Custom Fields", if you want to see the names of these ACFs you can look at 'src/pages/index.js' file on its graphql query or you can look at; https://github.com/svconectado/website/wiki
- Adding dotenv package
- Adding prettier rules in the ESLint config file - Fixing warnings files with the rules of prettier
- Adding page-template with the difference that this template doesn't show the title and author information
The header component only will be displayed on the main page of the website. The menu component has a scroll eventListener, this event is to set the menu background when the route is "/" because the menu component won't have background and image when is in the top of the page, in the other pages, the menu will have background and image and the scroll eventListener will be disabled. - Updating menu component file - Updating layout component to receive showHeader prop - Updating the page-template to display the title page
- Adding 404 image
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antes de enviar el Pull Request
Descripción
Capturas