-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: support Rolldown #13747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support Rolldown #13747
Conversation
|
@@ -102,8 +101,7 @@ export async function build_service_worker( | |||
'service-worker': service_worker_entry_file | |||
}, | |||
output: { | |||
// .mjs so that esbuild doesn't incorrectly inject `export` https://github.com/vitejs/vite/issues/15379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this seems like it'd break when using esbuild. perhaps we should remove it only when using rolldown
Testing integration with https://github.com/vitejs/rolldown-vite
TODOS
preserveEntrySignatures
when it's implemented [Feature Request]: SupportpreserveEntrySignatures
option /preserveSignatures
inemitFile
rolldown/rolldown#3500rollupOptions.onwarn
setting not silencing the non-existent hook import messagesexperimental.enableNativePlugins
working https://vite.dev/guide/rolldown#enabling-native-plugins currently it causes styles to not be appliedbuild.watch
to be implemented in vite rolldownesbuildOptions
andtransformWithEsbuild
and other esbuild stuff invite-plugin-svelte
with the oxc/rolldown equivalentPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits