Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implict children tweaks #2285

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix: implict children tweaks #2285

merged 2 commits into from
Feb 7, 2024

Conversation

dummdidumm
Copy link
Member

- ignore comments when determining whether or not to add an implicit children prop #2263
- do static analysis of the destructuring to see whether or not children is destructured from `$props()`, and if not, add the implicit children prop if there's a slot. This results in less confusing type errors when transforming to runes mode and using a slot
@dummdidumm dummdidumm merged commit efe8463 into master Feb 7, 2024
2 checks passed
@dummdidumm dummdidumm deleted the implicit-children-fixes branch February 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant