fix: handle issues with svelte file watching #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. This should fix #2419. The trigger is file save, once the file is saved it'll be marked as closed so further diagnostic is skipped. |
|
From my testing the issue was also the missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the neovim file-watching issue mentioned in Discord. And most likely #2419. One possible reason for #2419 is with projects without tsconfig/jsconfig. Because of the wrong client svelte file checking logic, When the file is updated in the file system it gets overridden by the file system version so it longer is client file and thus removed in the typescript program.