feat: support typescript 5.6 #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlyu123
commented
Oct 27, 2024
| @@ -191,6 +219,7 @@ describe('CompletionProviderImpl', function () { | |||
|
|
|||
| assert.deepStrictEqual(eventCompletions, <CompletionItem[]>[ | |||
| { | |||
| commitCharacters: [], | |||
There was a problem hiding this comment.
Empty array and undefined should behave the same but won't be overridden by itemDefaults
| @@ -1290,7 +1330,7 @@ describe('CompletionProviderImpl', function () { | |||
| insertText: undefined, | |||
| insertTextFormat: undefined, | |||
| labelDetails: undefined, | |||
| commitCharacters: ['.', ',', ';', '('], | |||
| commitCharacters: [], | |||
There was a problem hiding this comment.
This one is returned by the TypeScript. The TypeScript PR mentioned it is to prevent something like this from triggering accepting completion suggestions. It was added to VSCode first and then migrated to TypeScript.
someFunction(`somting.`)
function someFunction(str: 'something.a', 'something.b') {}
dummdidumm
added a commit
that referenced
this pull request
Nov 5, 2024
Because Svelte components take precedence, we leave out commit characters to not auto complete in weird places (e.g. when you have `foo.filter(a => a)`) and get autocomplete for component A, then a commit character of `.` would auto import the component which is not what we want Found after merging #2545 and playing around with it a bit
dummdidumm
added a commit
that referenced
this pull request
Nov 5, 2024
) Because Svelte components take precedence, we leave out commit characters to not auto complete in weird places (e.g. when you have `foo.filter(a => a)`) and get autocomplete for component A, then a commit character of `.` would auto import the component which is not what we want Found after merging #2545 and playing around with it a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bumped typescript-auto-import-cache for #2541, but there is no test for it. I am not really sure what the exact condition triggering this is, but the problem is that the caching implementation of typescript-auto-import-cache is out of sync with TypeScript 5.6. TypeScript added another parameter for some functions.
This adds support for Exclude Patterns for Auto-Imports and Granular Commit Characters. The commit characters should use the result from TypeScript when supported, The old one is slightly tweaked and serve as a fallback for older typescript version. This also utilizes the new itemDefaults in LSP 3.17 to reduce some serialization costs when supported. The idea is to reduce the duplicated stuff in completion-items so that communication between the client and server can save some serialization/parsing work.