Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fall back to any instead of unknown for untyped $props #2582

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dummdidumm
Copy link
Member

The idea was to be conservative about it, but this causes problems for people not wanting strict type checking but only a basic form of it. Falling back to any is the more pragmatic choice

#2556

@jasonlyu123 any reservations against this?

The idea was to be conservative about it, but this causes problems for people not wanting strict type checking but only a basic form of it. Falling back to `any` is the more pragmatic choice

#2556
@jasonlyu123
Copy link
Member

Ok with fallback to any. There seem to be many more people who got confused about it since the stable release is out 😅. We'll lose the ability to warn people who forgot to type the props. But at least for me that doesn't happen very often.

@dummdidumm dummdidumm merged commit 77160ff into master Nov 12, 2024
3 checks passed
@dummdidumm dummdidumm deleted the any-instead-of-unknown branch November 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants