fix: wrap each block expression in derived to encapsulte effects #14967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dcd124b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
preview: https://svelte-dev-git-preview-svelte-14967-svelte.vercel.app/ this is an automated message |
|
Rich-Harris
reviewed
Jan 10, 2025
Rich-Harris
approved these changes
Jan 10, 2025
Merged
dummdidumm
added a commit
that referenced
this pull request
Jan 13, 2025
closes #14991 - at least to the extent possible Also adjusts a comment which a) did not hint at why it's needed in the first place (was added in #14967) b) sounded like we could change that in the future, but we can't, because people will always have the ability to trigger reactivity through other means without changing the array reference
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14961.
We have logic in the each block today that assumes that the child effects of an each block effect are always the entries of the each block. This is not correct – as the expression used to get the collection for the each block might also create its own effects. Previously, we'd override the effects created from
get_collectionand it would cause a bunch of issues.To avoid this, we can wrap the collection expression in a derived that enables us to instead put the effects associated with that collection with the derived rather than the each block effect.