fix: support camelCase properties on custom elements #9328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while attributes are case insensitive, properties are not. to not introduce a breaking change, the lowercased variant is checked first. fixes #9325
🦋 Changeset detectedLatest commit: 8a9fcab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Oct 18, 2023
Merged
| @@ -480,7 +480,10 @@ export function set_custom_element_data_map(node, data_map) { | |||
| /** | |||
| * @returns {void} */ | |||
| export function set_custom_element_data(node, prop, value) { | |||
| if (prop in node) { | |||
| const lower = prop.toLowerCase(); // for backwards compatibility with existing behavior we do lowercase first | |||
| if (lower in node) { | |||
There was a problem hiding this comment.
I don't think this is a particularly good thing to do. Can you remove this in Svelte 5?
There was a problem hiding this comment.
Yes, we'll likely do that
kelvinsjk
pushed a commit
to kelvinsjk/svelte
that referenced
this pull request
Oct 19, 2023
while attributes are case insensitive, properties are not. to not introduce a breaking change, the lowercased variant is checked first. fixes sveltejs#9325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while attributes are case insensitive, properties are not. to not introduce a breaking change, the lowercased variant is checked first. fixes #9325
Svelte compiler rewrite
Please note that the Svelte codebase is currently being rewritten. Thus, it's best to hold off on new features or refactorings for the time being.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint