Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with CSS nesting adding semi colons after rule declarations #9343

Closed
wants to merge 72 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
fe8a9ce
breaking: init Svelte 5
dummdidumm Nov 10, 2023
b8ea454
chore: enter changeset prerelease mode
dummdidumm Nov 10, 2023
c6c934a
chore: cleanup (#9381)
dummdidumm Nov 10, 2023
341810b
chore: don't format changeset folder
dummdidumm Nov 10, 2023
28b5603
Version Packages (next) (#9382)
github-actions[bot] Nov 10, 2023
c732bf8
Merge branch 'main' of https://github.com/sveltejs/svelte
dummdidumm Nov 10, 2023
14d7424
fix symlink (hopefully) (#9383)
Rich-Harris Nov 10, 2023
51394a4
docs: note more breaking changes
dummdidumm Nov 10, 2023
2aacfad
fix: exclude internal props from spread attributes (#9384)
Rich-Harris Nov 10, 2023
7bcd33d
Fix diagnostics (#9385)
Rich-Harris Nov 10, 2023
304a29e
fix runes mode indicator (#9388)
Rich-Harris Nov 11, 2023
7a84e78
fix: add snippet symbol to children prop (#9395)
gtm-nayan Nov 12, 2023
6d7caf3
chore: update PR template (#9397)
benmccann Nov 12, 2023
11eead7
lint
Rich-Harris Nov 13, 2023
2ae9539
enable dev mode for preview repl (#9393)
gtm-nayan Nov 13, 2023
9a99554
breaking: remove Component type, keep using SvelteComponent instead (…
dummdidumm Nov 13, 2023
1daadc3
chore: add missing svelte/transition functions (#9391)
wbhob Nov 13, 2023
5a6afe5
fix: correct each block update index type (#9425)
trueadm Nov 13, 2023
8798f3b
chore: split $.each into $.each_keyed/$.each_indexed (#9422)
trueadm Nov 13, 2023
17e6c4f
fix: address runtime effect issues (#9417)
trueadm Nov 13, 2023
5768df1
chore: remove selector api (#9426)
trueadm Nov 13, 2023
a990e57
fix tsconfig.json (#9427)
Rich-Harris Nov 13, 2023
9fc8726
skip svelte.dev deploy. this may or may not work (#9424)
Rich-Harris Nov 13, 2023
1fd77d7
Version Packages (next) (#9386)
github-actions[bot] Nov 13, 2023
9aa06bd
fix: check that snippet is not rendered as a component (#9423)
dummdidumm Nov 13, 2023
7ab03ae
fix: add missing files binding (#9415)
dummdidumm Nov 13, 2023
66661ef
chore: use internal `get_descriptors` helper (#9389)
Rich-Harris Nov 14, 2023
a6fdc47
chore: show ast on playground (#9440)
baseballyama Nov 14, 2023
da37c92
fix: support dynamic attributes containing call expressions (#9443)
trueadm Nov 14, 2023
cf63220
fix: ensure keyed fallback to indexed (#9441)
trueadm Nov 14, 2023
3f56baf
blog: fix typo in 'svelte.dev: A complete overhaul' blog entry (#9438)
arpitjalan Nov 14, 2023
73ae5ef
fix: tighten up event attributes and hoisting logic (#9433)
trueadm Nov 14, 2023
e90ded6
fix: allow svelte:self in snippets (#9439)
paoloricciuti Nov 14, 2023
6bba70a
Docs (#9449)
Rich-Harris Nov 14, 2023
f18adc8
docs: Update Breaking changes section (#9444)
baseballyama Nov 14, 2023
9abfb52
add back launch config
Rich-Harris Nov 15, 2023
6f6c3a0
fix: only escape attribute values for elements, not components (#9456)
Rich-Harris Nov 15, 2023
f5101c0
treat `slot` the same as other props - closes #9455 (#9457)
Rich-Harris Nov 15, 2023
9eb969d
fix: address bug in before/after update (#9448)
trueadm Nov 15, 2023
6f3dc04
fix: allow member access on directives (#9462)
paoloricciuti Nov 15, 2023
9ef3424
fix: support class exports (#9465)
dummdidumm Nov 15, 2023
640dd48
chore: remove obsolete script
dummdidumm Nov 15, 2023
73e8820
chore: make DOM operations lazily init (#9468)
trueadm Nov 15, 2023
d749685
fix: rework directive name handling (#9470)
Rich-Harris Nov 15, 2023
2ebedb0
configure search.exclude (#9472)
Rich-Harris Nov 15, 2023
e3e1fef
fix: stringify attribute values before comparison (#9475)
Rich-Harris Nov 15, 2023
455fa89
Code golf each transitions (#9476)
trueadm Nov 15, 2023
555e8f8
enforce treeshakeability (#9430)
Rich-Harris Nov 15, 2023
19f84ca
fix: Added missing context of `svelte.js` for validation (#9394)
baseballyama Nov 15, 2023
c1f6ee0
fix: handle dynamic selects with falsy select values (#9471)
dummdidumm Nov 15, 2023
7e94dee
Version Packages (next) (#9431)
github-actions[bot] Nov 15, 2023
60c273e
Revert "fix: address bug in before/after update" (#9480)
trueadm Nov 15, 2023
c823dd2
Version Packages (next) (#9481)
github-actions[bot] Nov 16, 2023
755fe33
chore: add AST output to sandbox (#9488)
Rich-Harris Nov 16, 2023
37f2493
allow setting files (#9463)
eltigerchino Nov 16, 2023
ede1edd
fix: emit useful error on invalid binding to derived state (#9497)
Rich-Harris Nov 16, 2023
c827b0c
fix: only treat instance context exports as accessors (#9500)
Rich-Harris Nov 16, 2023
687b8f5
docs: fix typo in Svelte 5 preview docs (#9507)
eriandev Nov 17, 2023
1beb5e8
fix: tweak script/style tag parsing/preprocessing logic (#9502)
dummdidumm Nov 17, 2023
4418ba6
fix: add top level snippets to instance scope (#9467)
dummdidumm Nov 17, 2023
3780939
fix: ensure we visit assignments during compilation (#9511)
trueadm Nov 17, 2023
3b2e6ea
fix: address unowned propagation signal issue (#9510)
trueadm Nov 17, 2023
e0271f0
Version Packages (next) (#9492)
github-actions[bot] Nov 17, 2023
f886bc1
fix: handle intro global transition propagation correctly (#9515)
trueadm Nov 17, 2023
a36dba7
Version Packages (next) (#9519)
github-actions[bot] Nov 17, 2023
bbd1a6c
chore: tune signals for better runtime perf (#9529)
trueadm Nov 18, 2023
298da65
chore: more signal fine-tuning (#9531)
trueadm Nov 18, 2023
b0588d7
fix: address intro transition bugs (#9528)
trueadm Nov 18, 2023
5458ea7
Version Packages (next) (#9530)
github-actions[bot] Nov 18, 2023
5809ac6
chore: rename internal object properties (#9532)
trueadm Nov 18, 2023
699c337
Version Packages (next) (#9535)
github-actions[bot] Nov 19, 2023
bd2a586
chore: more transition code-golfing (#9536)
trueadm Nov 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
5 changes: 5 additions & 0 deletions .changeset/afraid-moose-matter.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: tweak script/style tag parsing/preprocessing logic
5 changes: 5 additions & 0 deletions .changeset/brave-walls-destroy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: use internal `get_descriptors` helper
5 changes: 5 additions & 0 deletions .changeset/brown-spoons-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

revert: address bug in before/after update
5 changes: 5 additions & 0 deletions .changeset/chilly-dolphins-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: remove selector api
5 changes: 5 additions & 0 deletions .changeset/clean-eels-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: emit useful error on invalid binding to derived state
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"fixed": [],
"linked": [],
"access": "public",
"baseBranch": "svelte-4",
"baseBranch": "main",
"bumpVersionsWithWorkspaceProtocolOnly": true,
"ignore": ["!(@sveltejs/*|svelte)"]
}
5 changes: 5 additions & 0 deletions .changeset/cuddly-pianos-drop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: improve bundle code size
5 changes: 5 additions & 0 deletions .changeset/curly-lizards-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: coerce attribute value to string before comparison
5 changes: 5 additions & 0 deletions .changeset/early-ads-tie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: rename internal object properties
5 changes: 5 additions & 0 deletions .changeset/eight-steaks-shout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: correct update_block index type
5 changes: 5 additions & 0 deletions .changeset/eighty-bikes-camp.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: handle private fields in `class` in `.svelte.js` files
5 changes: 5 additions & 0 deletions .changeset/fifty-steaks-float.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: address unowned propagation signal issue
5 changes: 5 additions & 0 deletions .changeset/fresh-weeks-trade.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: make operations lazy
5 changes: 5 additions & 0 deletions .changeset/funny-wombats-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: allow svelte:self in snippets
5 changes: 5 additions & 0 deletions .changeset/good-pianos-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: check that snippet is not rendered as a component
5 changes: 5 additions & 0 deletions .changeset/honest-icons-change.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

patch: ensure keyed each block fallback to indexed each block
5 changes: 5 additions & 0 deletions .changeset/hungry-dots-fry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: more signal perf tuning
5 changes: 5 additions & 0 deletions .changeset/itchy-lions-wash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: allow member access on directives
5 changes: 5 additions & 0 deletions .changeset/khaki-mails-draw.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: tighten up signals implementation
5 changes: 5 additions & 0 deletions .changeset/kind-deers-lay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: more transition code-golfing
5 changes: 5 additions & 0 deletions .changeset/lazy-spiders-think.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: handle dynamic selects with falsy select values
5 changes: 5 additions & 0 deletions .changeset/lucky-schools-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure dynamic attributes containing call expressions update
5 changes: 5 additions & 0 deletions .changeset/moody-owls-cry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: exclude internal props from spread attributes
5 changes: 5 additions & 0 deletions .changeset/odd-needles-joke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: address intro transition bugs
5 changes: 5 additions & 0 deletions .changeset/poor-eggs-enjoy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: add missing files binding
50 changes: 50 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{
"mode": "pre",
"tag": "next",
"initialVersions": {
"svelte": "5.0.0-next.0",
"svelte-playgrounds-demo": "0.0.1",
"svelte-playgrounds-sandbox": "0.0.1",
"svelte-5-preview": "0.5.0",
"svelte.dev": "1.0.0"
},
"changesets": [
"afraid-moose-matter",
"brave-walls-destroy",
"brown-spoons-boil",
"chilly-dolphins-lick",
"clean-eels-beg",
"cuddly-pianos-drop",
"curly-lizards-dream",
"early-ads-tie",
"eight-steaks-shout",
"eighty-bikes-camp",
"fifty-steaks-float",
"fresh-weeks-trade",
"funny-wombats-argue",
"good-pianos-jump",
"honest-icons-change",
"hungry-dots-fry",
"itchy-lions-wash",
"khaki-mails-draw",
"lazy-spiders-think",
"lucky-schools-hang",
"moody-owls-cry",
"odd-needles-joke",
"poor-eggs-enjoy",
"quiet-camels-mate",
"rich-sheep-burn",
"rotten-buckets-develop",
"sharp-gorillas-impress",
"shiny-shrimps-march",
"small-papayas-laugh",
"soft-geese-learn",
"sour-rules-march",
"strong-lemons-provide",
"tall-shrimps-worry",
"thirty-flowers-sit",
"thirty-ghosts-fix",
"tiny-kings-whisper",
"wicked-doors-train"
]
}
5 changes: 5 additions & 0 deletions .changeset/quiet-camels-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: improve keyblock treeshaking
5 changes: 5 additions & 0 deletions .changeset/rich-sheep-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: add top level snippets to instance scope
5 changes: 5 additions & 0 deletions .changeset/rotten-buckets-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

breaking: svelte 5 alpha
5 changes: 5 additions & 0 deletions .changeset/sharp-gorillas-impress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: only treat instance context exports as accessors
5 changes: 5 additions & 0 deletions .changeset/shiny-shrimps-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: do not propagate global intro transitions
5 changes: 5 additions & 0 deletions .changeset/small-papayas-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

breaking: remove Component type, keep using SvelteComponent instead
5 changes: 5 additions & 0 deletions .changeset/soft-geese-learn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: allow setting files binding for `<input type="file" />`
5 changes: 5 additions & 0 deletions .changeset/sour-rules-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: only escape attribute values for elements, not components
5 changes: 5 additions & 0 deletions .changeset/strong-lemons-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: handle event attribute spreading with event delegation
5 changes: 5 additions & 0 deletions .changeset/tall-shrimps-worry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: add snippet marker symbol to children prop
5 changes: 5 additions & 0 deletions .changeset/thirty-flowers-sit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: support class exports
5 changes: 5 additions & 0 deletions .changeset/thirty-ghosts-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

chore: tweak signals for better runtime perf
5 changes: 5 additions & 0 deletions .changeset/tiny-kings-whisper.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: treat `slot` the same as other props
5 changes: 5 additions & 0 deletions .changeset/wicked-doors-train.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: add missing visitor for assignments during compilation
23 changes: 23 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# NOTE: In general this should be kept in sync with .eslintignore

**/dist/**
**/config/**
**/build/**
**/playgrounds/sandbox/**
**/npm/**
**/*.js.flow
**/*.d.ts
**/playwright*/**
**/vite.config.js
**/vite.prod.config.js
**/node_modules

**/tests/**

# documentation can contain invalid examples
documentation/**

# contains a fork of the REPL which doesn't adhere to eslint rules
sites/svelte-5-preview/**
# Wasn't checked previously, reenable at some point
sites/svelte.dev/**
54 changes: 54 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
module.exports = {
extends: ['@sveltejs'],

// TODO: add runes to eslint-plugin-svelte
globals: {
$state: true,
$derived: true,
$effect: true,
$props: true
},

overrides: [
{
// scripts and playground should be console logging so don't lint against them
files: ['playgrounds/**/*', 'scripts/**/*'],
rules: {
'no-console': 'off'
}
},
{
// the playgrounds can use public naming conventions since they're examples
files: ['playgrounds/**/*'],
rules: {
'lube/svelte-naming-convention': 'off'
}
},
{
files: ['packages/svelte/src/compiler/**/*'],
rules: {
'no-var': 'error'
}
}
],

plugins: ['lube'],

rules: {
'no-console': 'error',
'lube/svelte-naming-convention': ['error', { fixSameNames: true }],
// eslint isn't that well-versed with JSDoc to know that `foo: /** @type{..} */ (foo)` isn't a violation of this rule, so turn it off
'object-shorthand': 'off',
'no-var': 'off',

// TODO: enable these rules and run `pnpm lint:fix`
// skipping that for now so as to avoid impacting real work
'@typescript-eslint/array-type': 'off',
'@typescript-eslint/no-namespace': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-unused-vars': 'off',
'prefer-const': 'off',
'svelte/valid-compile': 'off',
quotes: 'off'
}
};
6 changes: 4 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## Svelte compiler rewrite
## Svelte 5 rewrite

Please note that [the Svelte codebase is currently being rewritten](https://svelte.dev/blog/runes). Thus, it's best to hold off on new features or refactorings for the time being.
Please note that [the Svelte codebase is currently being rewritten for Svelte 5](https://svelte.dev/blog/runes). Changes should target Svelte 5, which lives on the default branch (`main`).

If your PR concerns Svelte 4 (including updates to [svelte.dev.docs](https://svelte.dev/docs)), please ensure the base branch is `svelte-4` and not `main`.

### Before submitting the PR, please make sure you do the following

Expand Down
Loading