[@svelteui/core]: add new drawer component #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mineofcode
commented
Mar 5, 2023
mineofcode
commented
BeeMargarida
changed the title
BeeMargarida
added
enhancement
BeeMargarida
reviewed
Mar 7, 2023
BeeMargarida
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Could you also include the logic for the focus return, similar to what we have in Modal. It was recently added there, so it would be cool to also have in this component.
BeeMargarida
reviewed
Mar 7, 2023
| display: 'block', | ||
| wordBreak: 'break-word' | ||
| }, | ||
| Drawer: { |
There was a problem hiding this comment.
nitpicking but
Suggested change
| Drawer: { | |
| drawer: { |
| display: 'flex', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| marginBottom: parseInt(theme.space.md.value), |
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| marginBottom: parseInt(theme.space.md.value), | ||
| marginRight: -9 |
There was a problem hiding this comment.
Suggested change
| marginRight: -9 | |
| marginRight: '-9px' |
| }, | ||
|
|
||
| body: { | ||
| maxHeight: overflow === 'inside' ? 'calc(100vh - 185px)' : null, |
There was a problem hiding this comment.
any specific reason for the 185px?
| $: if (opened) { | ||
| setTimeout(() => { | ||
| openStyle = position + `: 0px;`; | ||
| }, 100); |
| </div> | ||
| {/if} | ||
| <div id={bodyId} class={classes.body}> | ||
| <slot>Place some content</slot> |
|
Hi @masagatech, any updates regarding this? Do you need any help? |
|
@mineofcode still want to finish this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.