Fix current tests #220
Fix current tests #220
Conversation
Looks like some installed sphinx extensions failed loading now on 4.3 Didn't investigate further why ( dependency version mismatch ?)
I got rate limited with the python uploader. It's been deprecated and its repo archived.
There was a problem hiding this comment.
This is awesome, thank you so much! There are some changes here that I need to pay closer attention to. Additionally, the attempt to clear today had to get reverted... helping a pregnant couple get their house ready for a baby on the way.
You are reaching out at a slightly difficult time for me. I need to be able to find time to carve out a couple of hours to smash this all through; but I'm also trying to get a big deliverable ready before going on vacation for a week (8-14 - 8/21). So while I sincerely hope to find the time to get through this, it will be small chunks here and there over the next few days.
Thank you again for helping update things and get everything working. If I get stuck on some parts or can't support the change, I'll revert it on this PR. The sphinx changes are interesting. It seems like we'll be skipping tests for broken configurations, but I may want to add one back for our rosdoc folks (that ecosystem is slow to evolve).
To be continued.
| python-version: ${{ matrix.python-version }} | ||
| os: ${{ matrix.os }} | ||
| sphinx_version_range: '==${{ env.MINIMUM_SUPPORTED_SPHINX_VERSION }}' | ||
| codecov_token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
TODO: @svenevs add codecov token
|
No worries, I'm not in a hurry. |
|
Gentle poke @svenevs |
|
Gah I'm so sorry :/ I'm moving the next few days but have set a reminder for this weekend... |
|
Hi there, just wanted to check in, I had to move the reminders back, I need to finish getting settled before work tomorrow and unfortunately have a lot to catch up on this week. But now that the dust is settling and I have a better living arrangement I will be able to get the needed facelift here through. I'm sorry this keeps falling off the radar, I've got numerous calendar reminders and sticky notes up. Thank you for being patient, it's been a rough couple of months :/ |
|
Hey, it's me again 👋 offering support in moving this along if needed |
The current tests now all pass in my fork. Couple of notes:
CODECOV_TOKENrepo secretCPPFOrtranMixed.tests_hierarchiesfails. For some reason the checked functions have an additionalintent(in)argument. I've just ignored that.