Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataFrameShow): Remove extra new lines #163

Open
wants to merge 121 commits into
base: main
Choose a base branch
from

Conversation

tools4origins
Copy link
Collaborator

A regression was introduced in the latest commit on master:

spark.range(3).show() printed not wanted blank lines:

+---+
| id|
+---+
|  0|
<BLANK LINE>
|  1|
<BLANK LINE>
|  2|
<BLANK LINE>
+---+

This went unnoticed because doctest was configure to ignore whitespace differences, which we do not want for instance because of this regression, hence the removal in setup.cfg

@tools4origins
Copy link
Collaborator Author

This PR which only modifies two lines fails on an unrelated issue because there was a modification of an external library (isort).

It's again an example of the issue mentioned in #157 (comment)

The solution would be to align the code with a recent version of isort and fix this version in the requirements (this is done in #157)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants