Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background for intro.svsticky.nl #1112

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

TobiasDeBruijn
Copy link
Member

The old one was due to be replaced.

Copy link
Contributor

@SpookyBoy99 SpookyBoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it needs a new background, however, I do think this one shows alcohol to prominently (ideally there would be no alcohol in the picture, but this limits your options severely).

Secondly, this picture has many people prominently showing their faces of which you have to ask consent before merging the pull request (if not given consent by all, either delete the branch or squash commits, so the image will no longer be publicly available).

My suggestions for a background:

@TobiasDeBruijn
Copy link
Member Author

Fair enough fair enough yeah. I like the 4th picture the most I think (https://fotos.svsticky.nl/introductie-2023---usp-tour-&-walking-dinner/ed9d6a86-6573-4908-88a7-a486a88ab022/) though I don't know the names of the two in front, so I cannot ask them for consent (help me out here 😇 )

@SpookyBoy99
Copy link
Contributor

The board is discussing which one they find most appropriate (number 4 is a high contender). Once the decision has been made, I will touch up the picture and make sure it fits on the website, acquire consent and submit it to you so you can commit it again. In the meantime, you can enable squashing for this repository, unless you want to do a manual rewrite of the history, which is something I thoroughly do not recommend.

@SilasPeters
Copy link
Member

SilasPeters commented Jul 29, 2024

I am truely humbled that my pictures are to be considered for the intro site, but I have to be honest: I prefer the current picture.
The current picture really shows a group (and not just people's back) having fun together, with silly props and a keyboard (how IT). Also, there's a Sticky sticker. I can't quite put my thumb on it, but this picture has a special energy that the alternatives don't quite match.

I will see if I can propose another photo. Also, let me know which photo you would like to use, for I can then edit the original picture to have better light balance etc. The fourth option looks too yellow, and that's correctable.

@SilasPeters
Copy link
Member

SilasPeters commented Jul 29, 2024

I will see if I can propose another photo.

Perhaps my standards are too high, but I can't find any photo I believe best fits the intro website. During the next intro I will try to focus on such a picture.

Side note: this picture can be quite a funny alternative to this picture, for it shows some chaos and thus some character: Sticky is not just an association, it's welcoming and casual.

@TobiasDeBruijn
Copy link
Member Author

The board is discussing which one they find most appropriate (number 4 is a high contender)

Should I also throw up a ball with KB18?

@SpookyBoy99
Copy link
Contributor

Should I also throw up a ball with KB18?

Of course

@SilasPeters
Copy link
Member

SilasPeters commented Jul 29, 2024

If I were to choose between said options, I would also choose the fourth option.

@SpookyBoy99 SpookyBoy99 mentioned this pull request Jul 30, 2024
2 tasks
@SpookyBoy99
Copy link
Contributor

Number four has been chosen by the majority of the current and candidate board + Silas and consent has been given by all parties in the picture, so we are good to go

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me see if I can make the picture less yellow. Other than that, I am really looking forward to seeing the photo in production! ❤️

@SpookyBoy99
Copy link
Contributor

I would advise against that, if you look at #1114 you can see the yellow has been incorporated in the website design, giving it a warmer appearance and nice homogenous feel

@SilasPeters
Copy link
Member

🤔 time to review it then

@SpookyBoy99 SpookyBoy99 requested a review from SilasPeters August 1, 2024 16:15
@SilasPeters
Copy link
Member

Perhaps my standards are too high, but I can't find any photo I believe best fits the intro website

Oh wow, seeing the new photo in action makes me realize I love the change!

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Happy approve*

@SpookyBoy99 SpookyBoy99 merged commit 10c84e4 into master Aug 1, 2024
1 check passed
@SpookyBoy99 SpookyBoy99 deleted the update-intro-background branch August 1, 2024 16:57
@TobiasDeBruijn
Copy link
Member Author

💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants