add support for relative path in specs files for SpringMVC. #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BeingCoder thanks for the PR. Please use 4-space instead for code indentation in the Java files. |
wing328
added
Client: Java
Server: Spring
Enhancement: General
and removed
Client: Java
labels
|
@wing328 , adjusted the format, thx. |
|
@BeingCoder there are still tabs in the Java files. Please provide an example and retarget this for 2.3.0 branch instead as it might be a breaking change. |
|
cc @cbornet |
|
I'm not sure I understand what this does and I'm not sure I agree with it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
when we define basePath in spec like this petstore/v2, it normally means in the web container, petstore is the context path, v2 is global relative path for all resource path. so it is good to generate API with this relative path for @RequestMapping(value = "/v2/dogs"), also it is better to define the controller level mapping since controller is resource based.
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)