Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh actions v2 setup #126

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Gh actions v2 setup #126

merged 7 commits into from
Mar 26, 2024

Conversation

micryc
Copy link
Contributor

@micryc micryc commented Mar 14, 2024

No description provided.

@micryc micryc requested a review from frantuma March 14, 2024 13:12
@micryc micryc self-assigned this Mar 14, 2024
Copy link
Member

@frantuma frantuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also manually update to snapshot version if not already set

branches: ["v2"]
pull_request:
# The branches below must be a subset of the branches above
branches: ["master"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong branch?

NAMESPACE_NAME="swagger-oss"
K8S_OBJECT_TYPE="daemonsets"
K8S_OBJECT_NAME="swagger-petstore"
DEPLOY_IMAGE="swaggerapi/swagger-petstore:$SC_RELEASE_TAG"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong image name

uses: actions/setup-python@v4
with:
python-version: '3.10'
- name: Set up Java 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check first locally, possibly v2 only builds with java 8

runs-on: ubuntu-latest
strategy:
matrix:
java: [ 11 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check java possibly use 8, see above

runs-on: ubuntu-latest
strategy:
matrix:
java: [ 11 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java version see above

mvn versions:commit

#####################
### update all other versions in files around to the next snapshot or new release, including readme and gradle ###
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check which files need update, see comment for v31

mvn versions:commit

#####################
### update version in openapi.yaml file ###
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check which files need update, see comment for v31

id = lastReleaseId(tag)
payload = "{\"tag_name\":\"" + tag + "\", "
payload += "\"draft\":" + "false" + ", "
payload += "\"target_commitish\":\"" + "master" + "\"}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong branch?

result = ""

baseurl = "https://api.github.com/repos/swagger-api/swagger-petstore/pulls/"
content = ghApiClient.readUrl('repos/swagger-api/swagger-petstore/pulls?state=closed&base=master&per_page=100')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong branch?

payload += "\"body\":" + json.dumps(content) + ", "
payload += "\"draft\":" + "true" + ", "
payload += "\"prerelease\":" + "false" + ", "
payload += "\"target_commitish\":\"" + "master" + "\"}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong branch?

@micryc micryc requested a review from frantuma March 21, 2024 11:00
@micryc micryc merged commit fbd572f into v2 Mar 26, 2024
4 checks passed
@micryc micryc deleted the gh-actions-v2-setup branch March 26, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants