-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh actions v2 setup #126
Gh actions v2 setup #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also manually update to snapshot version if not already set
branches: ["v2"] | ||
pull_request: | ||
# The branches below must be a subset of the branches above | ||
branches: ["master"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong branch?
.github/workflows/deploy-docker.yml
Outdated
NAMESPACE_NAME="swagger-oss" | ||
K8S_OBJECT_TYPE="daemonsets" | ||
K8S_OBJECT_NAME="swagger-petstore" | ||
DEPLOY_IMAGE="swaggerapi/swagger-petstore:$SC_RELEASE_TAG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong image name
uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
- name: Set up Java 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check first locally, possibly v2 only builds with java 8
.github/workflows/maven-pulls.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
java: [ 11 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check java possibly use 8, see above
.github/workflows/maven.yml
Outdated
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
java: [ 11 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java version see above
CI/post-release.sh
Outdated
mvn versions:commit | ||
|
||
##################### | ||
### update all other versions in files around to the next snapshot or new release, including readme and gradle ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check which files need update, see comment for v31
CI/prepare-release.sh
Outdated
mvn versions:commit | ||
|
||
##################### | ||
### update version in openapi.yaml file ### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check which files need update, see comment for v31
CI/publishRelease.py
Outdated
id = lastReleaseId(tag) | ||
payload = "{\"tag_name\":\"" + tag + "\", " | ||
payload += "\"draft\":" + "false" + ", " | ||
payload += "\"target_commitish\":\"" + "master" + "\"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong branch?
CI/releaseNotes.py
Outdated
result = "" | ||
|
||
baseurl = "https://api.github.com/repos/swagger-api/swagger-petstore/pulls/" | ||
content = ghApiClient.readUrl('repos/swagger-api/swagger-petstore/pulls?state=closed&base=master&per_page=100') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong branch?
CI/releaseNotes.py
Outdated
payload += "\"body\":" + json.dumps(content) + ", " | ||
payload += "\"draft\":" + "true" + ", " | ||
payload += "\"prerelease\":" + "false" + ", " | ||
payload += "\"target_commitish\":\"" + "master" + "\"}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong branch?
No description provided.