Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Crouton Filter #13

Closed
wants to merge 3 commits into from
Closed

Conversation

samie-ya
Copy link
Contributor

  • Filter made to return List of Models

@cobycloud
Copy link
Contributor

please reach out to discuss the use case in more detail

@samie-ya
Copy link
Contributor Author

please reach out to discuss the use case in more detail

Hi, Coby.
When I started modifying crouton, I made sure it returned a Single Model when it used Query. But on the other endpoints, I had to use the Query to return multiple models. So I reversed it to it's Original return value of List[Model], for with and Without Query

@samie-ya
Copy link
Contributor Author

please reach out to discuss the use case in more detail

@cobycloud
Hey Coby, Can we discuss these changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we are creating a custom delimiter so that we can pass the query string as a query string. This seems like a non-standard workaround. Would like for us to revisit the approach to determine a standardized sustainable solution.

@cobycloud cobycloud closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants