refactor(atoms): Remove JsWord alias
#10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c08f9af The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kdy1
force-pushed
the
graphite-base/10071
branch
from
eee826a to
1771222
Compare
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This was referenced Feb 21, 2025
Merge activity
|
CodSpeed Performance ReportMerging #10071 will degrade performances by 5.82%Comparing Summary
Benchmarks breakdown
|
2 tasks
github-merge-queue bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Mar 26, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> 1. `Pass` API swc-project/swc#9680 1. Replace all `chain!(` with `(` 2. Replace `-> impl Fold` with `-> impl Pass` 3. Replace `as_folder` with `visit_mut_pass` and `impl VisitMut + Fold` with `impl VisitMut + Pass` 2. `JsWord` has been removed swc-project/swc#10071 1. Replace `js_word!` with `atom!` 2. Replace `JsWord` with `Atom` 3. Bump `rustc-hash` to v2 swc-project/swc#9982 1. Replace `AHashMap` with `FxHashMap` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> 4. Due to the deprecation of `as_folder`, we need to self-implement `run_transform` rather than calling `compiler.transform`. For implementation details, refer to the SWC codebase at: - https://github.com/swc-project/swc/blob/main/crates/swc/src/lib.rs#L642 - https://github.com/swc-project/swc/blob/main/crates/swc/tests/projects.rs#L750 ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [x] Documentation updated (or not required). --------- Signed-off-by: BitterGourd <[email protected]> Co-authored-by: Qingyu Wang <[email protected]>
github-merge-queue bot
pushed a commit
to lynx-family/lynx-stack
that referenced
this pull request
Mar 26, 2025
<!-- Thank you for submitting a pull request! We appreciate the time and effort you have invested in making these changes. Please ensure that you provide enough information to allow others to review your pull request. Upon submission, your pull request will be automatically assigned with reviewers. If you want to learn more about contributing to this project, please visit: https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md. --> ## Summary <!-- Can you explain the reasoning behind implementing this change? What problem or issue does this pull request resolve? --> 1. `Pass` API swc-project/swc#9680 1. Replace all `chain!(` with `(` 2. Replace `-> impl Fold` with `-> impl Pass` 3. Replace `as_folder` with `visit_mut_pass` and `impl VisitMut + Fold` with `impl VisitMut + Pass` 2. `JsWord` has been removed swc-project/swc#10071 1. Replace `js_word!` with `atom!` 2. Replace `JsWord` with `Atom` 3. Bump `rustc-hash` to v2 swc-project/swc#9982 1. Replace `AHashMap` with `FxHashMap` <!-- It would be helpful if you could provide any relevant context, such as GitHub issues or related discussions. --> 4. Due to the deprecation of `as_folder`, we need to self-implement `run_transform` rather than calling `compiler.transform`. For implementation details, refer to the SWC codebase at: - https://github.com/swc-project/swc/blob/main/crates/swc/src/lib.rs#L642 - https://github.com/swc-project/swc/blob/main/crates/swc/tests/projects.rs#L750 ## Checklist <!--- Check and mark with an "x" --> - [x] Tests updated (or not required). - [x] Documentation updated (or not required). --------- Signed-off-by: BitterGourd <[email protected]> Co-authored-by: Qingyu Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a refactoring I always wanted to do