Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix toplevel option #10227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(es/minifier): Fix toplevel option #10227

wants to merge 2 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 18, 2025

Description:

Top-level compression should be enabled if the user specified, regardless of whether it's a module

@kdy1 kdy1 added this to the Planned milestone Mar 18, 2025
@kdy1 kdy1 self-assigned this Mar 18, 2025
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: ea2bec1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review March 18, 2025 07:10
@kdy1 kdy1 requested review from a team as code owners March 18, 2025 07:10
@kdy1 kdy1 changed the title fix(es): Fix option bug fix(es/minifier): Fix toplevel option Mar 18, 2025
@kdy1 kdy1 enabled auto-merge (squash) March 18, 2025 07:11
@kdy1 kdy1 disabled auto-merge March 18, 2025 07:11
@kdy1 kdy1 enabled auto-merge (squash) March 18, 2025 07:11
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #10227 will degrade performances by 1.38%

Comparing kdy1/minify-size (ea2bec1) with main (540bdf8)

Summary

❌ 1 regressions
✅ 151 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/lints/libs/d3 28 ms 28.4 ms -1.38%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant