Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template file before first recipe #1074

Closed

Conversation

mahermanns
Copy link
Contributor

@mahermanns mahermanns commented Feb 21, 2025

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Fixes #1073

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

Instead of using the file guacamole.md as a template. A different file template.md is initially created to fit the storyline of creating a template.

If any relevant discussions have taken place elsewhere, please provide links to these.

This topic came up in my teaching demo today, where @dpshelio suggested I propose a change, following what I did (in initially creating a file template.md).

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].

Copy link

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@mahermanns mahermanns closed this Feb 21, 2025
@mahermanns
Copy link
Contributor Author

Sorry. This PR actually contained the changes that I used in my teaching demo, which I now think could be fixed in a less intrusive way by #1075

@mahermanns mahermanns deleted the create-template-file-first branch February 24, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial recipe template already has a specific name.
1 participant