Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 06-ignore.md according to issue #891 #912

Closed
wants to merge 1 commit into from

Conversation

SvenMarcus
Copy link

Issue #891 proposed adding some additional comments on the creation of the .gitignore file to clarify that learners need to add the ignore patterns to the files themselves.

In issue swcarpentry#891 proposed to add some additional comments on the creation of the `.gitignore` file in order to clarify that learners need to add the ignore patterns to the files themselves.
Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of this is an approved recommendation; however, based on feedback from #710, it would be clearer if the change in line 51 is something similar to

We do this by creating a file in the root directory of our project called .gitignore. Then we'll add lines specifying which files we'd like to ignore in our project.

Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes starting on line 55 go against the standard of bash input/output used in the lesson. Please remove.

@kekoziar kekoziar added the status:changes requested Waiting for Contributor to update PR label Apr 29, 2023
@zkamvar
Copy link
Contributor

zkamvar commented May 8, 2023

Thank you for your contribution. This lesson has migrated to use The Carpentries Workbench, but unfortunately, due to various factors, the Maintainers of this lesson were unable to address this pull request before the transition. Because of this, we had to close your pull request.

Please note that this does not mean that your contribution was not valued. There are many reasons why a pull request is not merged. It's important to remember that the Maintainers are first and foremost people---people who maintain this lesson on a voluntary basis. Sometimes pull requests become stale because other responsibilities take precedence. Thank you for taking the time to open the pull request in the first place.

If you wish to contribute again, you will need to delete and re-fork your repository.

How to contribute

If you wish to contribute, you will need to use the following steps to delete,
re-fork, and re-create your pull request (aka the burn it all down
strategy
):

📹 How to update (delete) your fork https://carpentries.github.io/workbench/faq.html#update-fork-from-styles

  1. Save your edits on locally or in a scratch space.
  2. Delete your fork
  3. Create a new fork or use the "edit" button on the page you wish to edit.
  4. Apply your changes (NOTE The Workbench uses a different syntax. Here is a Transition Guide from Styles to Workbench for your reference).

Questions

If you have any questions or would like assistance, please contact @core-team-curriculum (email: [email protected]) or you can respond to this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-workbench status:changes requested Waiting for Contributor to update PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants