Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use spaces after commas #1059

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

edbennett
Copy link
Contributor

In both Python and English, it's considered good practice to use a space after a comma.

This PR adjusts both image captions and Python code snippets to consistently put spaces after commas, to demonstrate the style of code we would like people to write

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1059

The following changes were observed in the rendered markdown documents:

 02-numpy.md      |  4 ++--
 03-matplotlib.md |  4 ++--
 04-lists.md      |  2 +-
 06-files.md      | 10 +++++-----
 08-func.md       |  2 +-
 10-defensive.md  |  2 +-
 12-cmdline.md    |  2 +-
 md5sum.txt       | 14 +++++++-------
 8 files changed, 20 insertions(+), 20 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-27 15:30:53 +0000

github-actions bot pushed a commit that referenced this pull request Jul 27, 2023
@ineelhere ineelhere merged commit 49fe919 into swcarpentry:main Nov 7, 2023
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
Auto-generated via {sandpaper}
Source  : 49fe919
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-07 13:28:37 +0000
Message : Merge pull request #1059 from edbennett/going-to-space

always use spaces after commas
github-actions bot pushed a commit that referenced this pull request Nov 7, 2023
Auto-generated via {sandpaper}
Source  : acd769e
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-07 13:29:43 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 49fe919
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-07 13:28:37 +0000
Message : Merge pull request #1059 from edbennett/going-to-space

always use spaces after commas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants