Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not refer to NumPy array using the term list #1067

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

fiveop
Copy link
Contributor

@fiveop fiveop commented Oct 13, 2023

The description of the exercise used the term list, while the code in the solution used functions that we have so far only used with NumPy arrays (amax, amin). Even though these functions do take arguments of type list, learners might get confused (and teachers do get confused, because I thought up until I tested it right now, that surely numpy.amin etc. do not work on list type objects… :)).

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1067

The following changes were observed in the rendered markdown documents:

 10-defensive.md | 6 +++---
 md5sum.txt      | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-13 08:06:34 +0000

@ineelhere ineelhere self-requested a review November 12, 2023 06:40
github-actions bot pushed a commit that referenced this pull request Nov 12, 2023
episodes/10-defensive.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@ineelhere ineelhere merged commit a6859b9 into swcarpentry:main Nov 16, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
Auto-generated via {sandpaper}
Source  : a6859b9
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-16 20:10:09 +0000
Message : Merge pull request #1067 from fiveop/lists_arrays

Do not refer to NumPy array using the term list
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
Auto-generated via {sandpaper}
Source  : 4fd0d3b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-11-16 20:11:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a6859b9
Branch  : main
Author  : Indraneel Chakraborty <[email protected]>
Time    : 2023-11-16 20:10:09 +0000
Message : Merge pull request #1067 from fiveop/lists_arrays

Do not refer to NumPy array using the term list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants