Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor training loop from script to class #130

Closed
wants to merge 3 commits into from

Conversation

sweep-nightly[bot]
Copy link

@sweep-nightly sweep-nightly bot commented Oct 24, 2023

Description

This PR refactors the training loop from a script to a class in order to improve code organization and reusability. The existing code in src/main.py is encapsulated into a new class named MNISTTrainer, which includes methods for loading and preprocessing the data, defining the model, training the model, and saving the trained model.

Summary of Changes

  • Created a new class named MNISTTrainer in src/main.py.
  • Moved the code for loading and preprocessing the data into a method named load_data.
  • Moved the code for defining the model into a method named define_model.
  • Created a new method named train_model to implement the training loop.
  • Created a new method named save_model to save the trained model.
  • Updated the script to create an instance of MNISTTrainer and call the methods in the correct order.
  • Added proper documentation with docstrings and comments for all methods.

Please review and merge this PR. Thank you!

Fixes #6.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 24, 2023

Rollback Files For Sweep

  • Rollback changes to src/main.py
  • Rollback changes to src/main.py

@sweep-nightly
Copy link
Author

sweep-nightly bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Code should be properly formatted and indented.
  • Apply: Variable and function names should be descriptive and follow a consistent naming convention.
  • Apply: Imports should be organized and grouped together.
  • Apply: There should be no unused imports or variables.
  • Apply: Code should be properly commented and include docstrings for functions and classes.

@sweep-nightly sweep-nightly bot added the sweep label Oct 24, 2023
@sweep-nightly sweep-nightly bot closed this Oct 28, 2023
@sweep-nightly sweep-nightly bot deleted the sweep/refactor-training-loop_24 branch October 28, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: refactor the training loop from a script to a class in main.py
0 participants