Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/stripe intent duplicates #158

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

vstudenichnik-insoft
Copy link
Contributor

@vstudenichnik-insoft vstudenichnik-insoft commented Feb 7, 2024

https://app.asana.com/0/1202306318068147/1206492754384816/f

Description

During the investigation, it turned out that some browser extensions led to the duplication of all Vault requests (not only POST /intents). Vault requests are executed using JSONP, which may not work correctly due to browser extensions.
The fix is to use the fetch instead of <script src="***" /> request.

Testing

  • Added unit tests for the vaultRequest function.

Risk Assessment

  • This code change is higher risk
What is considered higher risk?
  • a regression would negatively impact many customers / core functionality, e.g.,
    • model framework
    • pricing / accounting / billing
    • payment integration
    • shared components
  • changes can't be undone so easily, e.g.,
    • API endpoint or model changes
    • destructive actions (e.g. deletes)
    • migration on large # of collections/documents

For Reviewers

This code has been reviewed for:

  • Technical approach
  • Risk assessment
  • Dependencies
  • Security
  • Test plan & coverage
  • Code organization
  • Code-style

@vstudenichnik-insoft vstudenichnik-insoft self-assigned this Feb 7, 2024
@awwit
Copy link
Contributor

awwit commented Feb 7, 2024

You need to return the dist directory back to its original state.

@vstudenichnik-insoft vstudenichnik-insoft marked this pull request as draft February 7, 2024 15:08
@vstudenichnik-insoft vstudenichnik-insoft force-pushed the fix/stripe-intent-duplicates branch from da8b590 to bb4f95a Compare February 7, 2024 15:31
@vstudenichnik-insoft vstudenichnik-insoft marked this pull request as ready for review February 7, 2024 16:30
@vstudenichnik-insoft
Copy link
Contributor Author

The main changes are in this commit.

@vstudenichnik-insoft vstudenichnik-insoft merged commit 0e610aa into master Feb 8, 2024
1 check passed
@vstudenichnik-insoft vstudenichnik-insoft deleted the fix/stripe-intent-duplicates branch February 8, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants