fix: some types to accept both Snake and Camel case objects #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: create utility type for CamelCase properties of any object feat: configure eslint for typescript declaration files feat: setting up a pre-commit hook for linting fix: errors detected by eslint fix: add important missing types and fields test validateNumber, validateExpiry, validateCVC
vstudenichnik-insoft
approved these changes
Apr 19, 2024
swellmike
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request does not contain functional changes.
Fixed many type definitions to accept object keys in Snake and Camel notations. The types were reviewed and updated in accordance with the data models. Also, some important missing fields have been added such as
purchase_optionfor order items.[DRY] Converting Snake object keys to Camel notation has been moved to a separate utility type.
Additionally,
eslintwas configured for linting*.d.tsfiles. Also, apre-commitgithookwas configured to perform linting code and tests before creating a commit. This will help us avoid critical type errors in the future.Bugs detected by eslint, such as unused variables and arguments, have been fixed. This was necessary for the linter to report new problems when executing git hooks.
Added skipped tests to validate card input.