Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPV6_RECVPKTINFO is the correct option to receive IPV6_PKTINFO #132

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

lhoward
Copy link
Contributor

@lhoward lhoward commented Nov 21, 2024

Haven't tested, try this though.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (150911e) to head (814d3f1).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   89.62%   90.02%   +0.40%     
==========================================
  Files          60       60              
  Lines        3932     3951      +19     
==========================================
+ Hits         3524     3557      +33     
+ Misses        408      394      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@swhitty
Copy link
Owner

swhitty commented Nov 21, 2024

passes for me on Darwin!

Screenshot 2024-11-22 at 10 44 24 am

@swhitty swhitty merged commit 8a5f9c7 into swhitty:main Nov 21, 2024
9 checks passed
@swhitty
Copy link
Owner

swhitty commented Nov 21, 2024

it works great, I've left the defaults unchanged but updated setPktInfo() to use the socket options so users (and tests) can get / set these options easily

#133

@lhoward
Copy link
Contributor Author

lhoward commented Nov 21, 2024

very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants