This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Short sample processing fixes #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you could rebase on master? |
|
@henryhallam yeah, looks like quite a bit has happened with peregrine recently. I'm on it. |
roamingryan
force-pushed
the
shortset-fixups
branch
from
5d71737
to
e22b722
Compare
added 13 commits
June 28, 2016 09:18
The tzdata database, also known as the Olsen, database seems to be the definitive source for leap second data. It is maintained regularly by folks who follow this stuff. The suggestion to use this database came from: https://stackoverflow.com/questions/19332902/extract-historic-leap-seconds-from-tzdata An alterate approach would be to include the tz repository as a submodule but this would quickly go stale. Therefore, I opted to pull the file from tzdata which should be regularly updated by the OS. The current location is suitable for Ubuntu, not sure about other OSes.
* track_correlate now accepts sample_freq directly, does not deal with settings objects * track_correlate returned complex-typed results track_correlate not found in libswiftnav, changed name per Cython config, probably not the appropriate fix Peregrine wasn't able to find the track_correlate function in libswiftnav. As I understand it, "*_" function names are generally not exposed to the user.
Nav bit hypothesis generator was missing a hypothesis possibility.
Here is an example of the erroneous behavior that this commit
fixes:
In [34]: nbh_old = peregrine.short_set.nav_bit_hypotheses(32)
In [35]: for i,n in enumerate(nbh_old):
print "%i\t"%i,"".join(["1" if a<0 else "0" for a in n])
....:
0 01111111111111111111111111111111
1 01111111111111111111100000000000
2 00111111111111111111111111111111
3 00111111111111111111110000000000
4 00011111111111111111111111111111
5 00011111111111111111111000000000
6 00001111111111111111111111111111
7 00001111111111111111111100000000
8 00000111111111111111111111111111
9 00000111111111111111111110000000
10 00000011111111111111111111111111
11 00000011111111111111111111000000
12 00000001111111111111111111111111
13 00000001111111111111111111100000
14 00000000111111111111111111111111
15 00000000111111111111111111110000
16 00000000011111111111111111111111
17 00000000011111111111111111111000
18 00000000001111111111111111111111
19 00000000001111111111111111111100
20 00000000000111111111111111111111
21 00000000000111111111111111111110
22 00000000000011111111111111111111
23 00000000000001111111111111111111
24 00000000000000111111111111111111
25 00000000000000011111111111111111
26 00000000000000001111111111111111
27 00000000000000000111111111111111
28 00000000000000000011111111111111
29 00000000000000000001111111111111 <--- Missing hypothesis
30 00000000000000000000011111111111 <--- between these two
31 00000000000000000000001111111111
32 00000000000000000000000111111111
33 00000000000000000000000011111111
34 00000000000000000000000001111111
35 00000000000000000000000000111111
36 00000000000000000000000000011111
37 00000000000000000000000000001111
38 00000000000000000000000000000111
39 00000000000000000000000000000011
40 00000000000000000000000000000001
41 00000000000000000000000000000000
…o microsample solver SHORT_SET: adds dilution of precision calculation SHORT_SET: adds option to return DOP values for solution SHORT_SET: adds option to return general metadata from processing attempt
roamingryan
force-pushed
the
shortset-fixups
branch
from
e22b722
to
f0f94b3
Compare
|
@henryhallam Rebase complete. I also cleaned up / squashed some of the commits. Should be good to land. It's not exactly proper unit testing, but processing of some representative samples yields numerically identical results before/after these changes. One exception are the velocity results which previously had a bug (fixed in 90e16cd). New results are in close agreement with alternative OD sources. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the recent activity on libswiftnav has broken Peregrine's short sample processing functionality.