Skip to content

[cas] Enable the CAS size limiting functionality for Swift caching #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

[cas] Enable the CAS size limiting functionality for Swift caching #410

merged 1 commit into from
Apr 15, 2025

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Apr 14, 2025

rdar://148443907

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Apr 14, 2025

@swift-ci Please test

@akyrtzi akyrtzi requested a review from cachemeifyoucan April 14, 2025 20:18
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Apr 14, 2025

Note that this requires associated swift-driver fix for the mechanism to take effect: swiftlang/swift-driver#1868

cachemeifyoucan
cachemeifyoucan approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akyrtzi akyrtzi merged commit a6d6d13 into swiftlang:main Apr 15, 2025
3 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/cas-size-limiting-for-swift branch April 15, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@mirza-garibovic mirza-garibovic Awaiting requested review from mirza-garibovic mirza-garibovic is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akyrtzi @neonichu @cachemeifyoucan