Skip to content

Setup a basic run of cmake-smoke-test in CI #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Setup a basic run of cmake-smoke-test in CI #480

merged 1 commit into from
May 5, 2025

Conversation

owenv
Copy link
Collaborator

@owenv owenv commented May 2, 2025

Add test coverage of the Cmake build

@owenv owenv force-pushed the owenv/cmake-ci branch 23 times, most recently from a24e15b to bd2ec17 Compare May 2, 2025 21:38
@@ -166,29 +168,18 @@ enum OS {
}

extension Process {
func run() async throws {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process execution is hanging the CI action, haven't fully debugged it yet

@owenv owenv force-pushed the owenv/cmake-ci branch 6 times, most recently from 3d6a592 to b95a058 Compare May 4, 2025 17:11
@owenv owenv force-pushed the owenv/cmake-ci branch 5 times, most recently from 479b177 to 142181b Compare May 4, 2025 20:39
@owenv owenv force-pushed the owenv/cmake-ci branch from 142181b to 90877bb Compare May 4, 2025 21:05
@owenv
Copy link
Collaborator Author

owenv commented May 4, 2025

@swift-ci test

@owenv owenv marked this pull request as ready for review May 4, 2025 21:38

var mostSignals = sigset_t()
sigemptyset(&mostSignals)
for i in 1 ..< SIGSYS {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..<SIGRTMAX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anything is using the realtime signals, and there could be a gap between SIGSYS and SIGRTMIN on some implementations

@owenv owenv merged commit 316345e into main May 5, 2025
23 of 24 checks passed
@owenv owenv deleted the owenv/cmake-ci branch May 5, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants