Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[region-isolation] Fix two small usage issues around diagnosing closure captures #77753

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[region-isolation] Fix two small usage issues around diagnosing closure captures #77753

wants to merge 2 commits into from
+55 −15

Conversation

gottesmm
Copy link
Contributor

Specifically:

  1. We were not mapping a type into the SILFunction's context and in the second case.
  2. We were wrapping CanTypes into a SILType and calling an API to check for non-Send ability. The second ignores that the type since it is from the AST may not be a lowered type... so I changed the underlying API to use CanTypes instead of SILTypes (since we did not need that in the first place) and changed the SILType API to just call that.

rdar://138667211

@gottesmm
[region-isolation] Fix code where we were not properly mapping a type…
d330de6 
… into a SILFunction's context to actually do so.

rdar://138667211
@gottesmm
[region-isolation] Add a SILIsolationInfo::isNonSendableType API that…
3748c7d 
… takes CanTypes and use it to avoid needing to lower certain CanTypes before performing the query.

rdar://138667211
@gottesmm gottesmm force-pushed the pr-c3a2f8fd038cfc5869c6ac318699115a8d10cd1b branch from 2a789eb to 3748c7d Compare November 20, 2024 23:34
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso Awaiting requested review from ktoso ktoso is a code owner

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gottesmm