Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1] [Completion] Fix crash in getTypeOfMember #77768

Merged

Conversation

hamishknight
Copy link
Contributor

6.1 cherry-pick of #77711

  • Explanation: Fixes a crash that could occur when attempting to do code completion on an existential with a superclass
  • Scope: Affects completion
  • Issue: rdar://138774888
  • Risk: Low, adds a new check, only affects completion
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

Make sure we only attempt to query the concrete
type for `Self` for a constrained protocol
extension.

rdar://138774888
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.1-dev labels Nov 21, 2024
@hamishknight hamishknight requested a review from a team as a code owner November 21, 2024 12:46
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 88312f6 into swiftlang:release/6.1 Dec 3, 2024
5 checks passed
@hamishknight hamishknight deleted the fix-completion-crash-6.1 branch December 3, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants