[windows][toolchain] Enable builtins and sanitizers #77770
Conversation
| @@ -66,6 +66,9 @@ If no such Windows SDK is installed, it will be downloaded from nuget. | |||
| Include the ds2 remote debug server in the SDK. | |||
| This component is currently only supported in Android builds. | |||
|
|
|||
| .PARAMETER IncludeSanitizers | |||
There was a problem hiding this comment.
What is the motivation for the new option? I think that if we are able to build the sanitizers, we should do that unconditionally. This has been a missing piece in our toolchain distribution, but it was left out due to the inability to get it to work rather than being intentionally left out.
There was a problem hiding this comment.
Yes agree in principle, but it will also add extra requirements for the default build. For example, the Visual Studio cross libs for Arm64 must be installed (which I had to do explicitly). We need to check if CI is prepared for that and maybe add a note in the quick-start docs right? If we keep it disabled by default, that wouldn't be necessary (now). I'd keep the option for a transition period and see. However, if you want it done now, no problem.
| if ($IncludeSanitizers) { | ||
| $InstallTo = "$($HostArch.ToolchainInstallRoot)\usr" | ||
| Invoke-BuildStep Build-Sanitizers Windows $ArchX64 $InstallTo | ||
| Invoke-BuildStep Build-Sanitizers Windows $ArchARM64 $InstallTo |
There was a problem hiding this comment.
We should do this for all the SDKs:
for ($Arch in $WindowsSDKArch) {
Invoke-BuildStep Build-Sanitizers Windows $Arch $($HostArch.ToolchainInstallRoot)\usr"
}
Profile and builtin libraries from compiler-rt are static and do not require a link step. We can enable them in our CMake caches and we can build and install them in the unified LLVM build step. Sanitizers contain dynamic libraries. We need the target-specific Visual Studio shell to perform the link step. This patch adds extra build steps in build.ps1 that reconfigure, build and install the target-specific build-trees in the LLVM runtimes directory through their respective Visual Studio shells.