[Cmake] Add debugdescription source file to swiftCore when needed #77777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,6 +239,11 @@ add_library(swiftCore | |||
| "${CMAKE_CURRENT_BINARY_DIR}/UnsafeRawBufferPointer.swift" | |||
| "${CMAKE_CURRENT_BINARY_DIR}/Tuple.swift") | |||
|
|
|||
| # https://github.com/swiftlang/swift/issues/77705 - Freestanding and Linux/Android builds both have failures to resolve. | |||
| if(NOT LINUX AND NOT ANDROID) | |||
There was a problem hiding this comment.
@compnerd Would it be preferred to use a cmake flag here which can be toggled on/off? Or will this suffice?
There was a problem hiding this comment.
I think that given that this is a workaround for an issue, leaving this focused as the specific cases is fine. I do wonder if the underlying issue has been resolved and this workaround is now outdated.
compnerd
approved these changes
Nov 21, 2024
| @@ -239,6 +239,11 @@ add_library(swiftCore | |||
| "${CMAKE_CURRENT_BINARY_DIR}/UnsafeRawBufferPointer.swift" | |||
| "${CMAKE_CURRENT_BINARY_DIR}/Tuple.swift") | |||
|
|
|||
| # https://github.com/swiftlang/swift/issues/77705 - Freestanding and Linux/Android builds both have failures to resolve. | |||
| if(NOT LINUX AND NOT ANDROID) | |||
There was a problem hiding this comment.
I think that given that this is a workaround for an issue, leaving this focused as the specific cases is fine. I do wonder if the underlying issue has been resolved and this workaround is now outdated.
etcwilde
approved these changes
Nov 21, 2024
|
@swift-ci test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source file
ObjectIdentifier+DebugDescription.swiftto the target when not building for Android or Linux