[6.1][Diagnostics] Support "swift" style diagnostics at EOF #77781
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the valid position checking and special handle EOF position. If the requested location is at EOF, use the last token, but still emit the diagnostics at the specificied location. rdar://138426038 (cherry picked from commit 40c8d81)
|
@swift-ci Please test |
DougGregor
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #77755 into
release/6.1Explanation: In the new diagnostic printing style, diagnostics at EOF were mistakenly ignored. This change fix that by adjusting the position checking logic, and also make sure it emits the diagnostics at the correct position.
Scope: Diagnostics
Risk: Low. The change is simple enough
Testing: Added a regression test case
Issues: rdar://129883075 rdar://138426038
Reviewers: Doug Gregor (@DougGregor), Hamish Knight (@hamishknight), and Alex Hoppen (@ahoppen)