Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] [AST] Remove assert from ModuleDecl::getFiles #77793

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

[6.1] [AST] Remove assert from ModuleDecl::getFiles #77793

wants to merge 1 commit into from
+0 −1

Conversation

hamishknight
Copy link
Contributor

  • Explanation: This can be hit for IsNonUserModuleRequest. On main this is properly fixed by enforcing that a ModuleDecl's files are immutable after construction ([AST] Remove ModuleDecl::addFile #77666).
  • Scope: N/A
  • Issue: rdar://137769081
  • Risk: None, this is just removing an assert
  • Testing: None, this is just removing an assert
  • Reviewer: Ben Barham

@hamishknight
[6.1] [AST] Remove assert from ModuleDecl::getFiles
177a564 
This can be hit for `IsNonUserModuleRequest`. On
main this is properly fixed by enforcing that a
ModuleDecl's files are immutable after construction.

rdar://137769081
@hamishknight hamishknight requested a review from a team as a code owner November 21, 2024 21:40
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham Awaiting requested review from bnbarham

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
swift 6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamishknight